fix: sanitisation failing to compare ids properly

opengovsg · Nov 16, 2023 · bccc3c2 · bccc3c2
1 parent 73c55e2
commit bccc3c2
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/app/modules/submission/encrypt-submission/encrypt-submission.utils.ts b/src/app/modules/submission/encrypt-submission/encrypt-submission.utils.ts
@@ -1,6 +1,7 @@
 import { StatusCodes } from 'http-status-codes'
 import _ from 'lodash'
 import moment from 'moment-timezone'
+import { Types } from 'mongoose'
 
 import {
   FormPaymentsField,
@@ -405,13 +406,13 @@ export const sanitisePaymentProducts = (
   form: IPopulatedEncryptedForm,
   dirtyPaymentProducts: ProductItem[] | undefined,
 ): ProductItem[] | undefined => {
-  if (!dirtyPaymentProducts) return dirtyPaymentProducts
-  if (!form.payments_field.products) return dirtyPaymentProducts
+  if (!dirtyPaymentProducts) return
+  if (!form.payments_field.products) return
 
   const sanitisedProducts = form.payments_field.products
     .map((cleanProductData): ProductItem | null => {
-      const dirtyProduct = dirtyPaymentProducts.find(
-        ({ data }) => data._id === cleanProductData._id,
+      const dirtyProduct = dirtyPaymentProducts.find(({ data }) =>
+        (cleanProductData._id as unknown as Types.ObjectId).equals(data._id),
       )
       if (!dirtyProduct) return null