Skip to content

Commit

Permalink
chore: fix from code review to remove unnecessary context and update …
Browse files Browse the repository at this point in the history
…pdfjs
  • Loading branch information
kathleenkhy committed May 7, 2024
1 parent a6ef373 commit ee12c01
Show file tree
Hide file tree
Showing 3 changed files with 157 additions and 16 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createContext, useCallback, useMemo } from 'react'
import { useCallback, useMemo } from 'react'
import { Droppable } from 'react-beautiful-dnd'
import {
Box,
Expand Down Expand Up @@ -48,12 +48,6 @@ interface FormBuilderProps extends FlexProps {
placeholderProps: DndPlaceholderProps
}

type OnCloseContext = {
onClose: () => void
}
export const MagicFormBuilderModalOnCloseContext =
createContext<OnCloseContext>({ onClose: () => undefined })

export const FormBuilder = ({
placeholderProps,
...props
Expand Down Expand Up @@ -112,14 +106,10 @@ export const FormBuilder = ({

return (
<>
<MagicFormBuilderModalOnCloseContext.Provider
value={{ onClose: magicFormBuilderModalDisclosure.onClose }}
>
<MagicFormBuilderModal
isOpen={magicFormBuilderModalDisclosure.isOpen}
onClose={magicFormBuilderModalDisclosure.onClose}
/>
</MagicFormBuilderModalOnCloseContext.Provider>
<MagicFormBuilderModal
isOpen={magicFormBuilderModalDisclosure.isOpen}
onClose={magicFormBuilderModalDisclosure.onClose}
/>
<Flex
mb={0}
flex={1}
Expand Down
150 changes: 150 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@
"dependencies": {
"@aws-sdk/client-cloudwatch-logs": "^3.536.0",
"@aws-sdk/client-lambda": "^3.414.0",
"@azure/openai": "^1.0.0-beta.11",
"@babel/runtime": "^7.24.1",
"@faker-js/faker": "^8.4.1",
"@azure/openai": "^1.0.0-beta.11",
"@joi/date": "^2.1.0",
"@opengovsg/formsg-sdk": "^0.12.0-alpha.1",
"@opengovsg/myinfo-gov-client": "^4.1.2",
Expand Down Expand Up @@ -134,6 +134,7 @@
"openid-client": "^5.3.1",
"opossum": "^7.1.0",
"p-queue": "^6.6.2",
"pdfjs-dist": "^4.2.67",
"promise-retry": "^2.0.1",
"promise-timeout": "^1.3.0",
"puppeteer-core": "22.6.3",
Expand Down

0 comments on commit ee12c01

Please sign in to comment.