Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update SMS OTP message #1085

Merged
merged 2 commits into from
Feb 10, 2021
Merged

feat: update SMS OTP message #1085

merged 2 commits into from
Feb 10, 2021

Conversation

jia1
Copy link
Member

@jia1 jia1 commented Feb 4, 2021

Closes #1068.

@jia1 jia1 self-assigned this Feb 4, 2021
@jia1 jia1 added the contribute free for contributors to pick up label Feb 4, 2021
@mantariksh
Copy link
Contributor

mantariksh commented Feb 5, 2021

not sure why CodeQL suddenly decided to flag these issues - let me fix them separately so you can rebase this PR

edit: all dismissed as false positives, no need to rebase!

Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry had another thought!

src/app/services/sms/sms.service.ts Show resolved Hide resolved
@jia1 jia1 requested a review from mantariksh February 9, 2021 11:47
@mantariksh mantariksh merged commit 9682bb5 into develop Feb 10, 2021
@karrui karrui deleted the feat/update-sms-otp-msg branch April 21, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute free for contributors to pick up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SMS OTP message copy
2 participants