Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Release 4.58.1 hotfix - mobile signature validation #1151

Merged
merged 2 commits into from
Feb 16, 2021
Merged

fix: Release 4.58.1 hotfix - mobile signature validation #1151

merged 2 commits into from
Feb 16, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Feb 16, 2021

Problem

  • Mobile number signature validation was dropped during migration to ts for mobile number validator

Solution

  • Add signature validation to mobile number validator

Tests

  • Create verified mobile field. Check that submission of verified mobile number works normally
  • Clone network request and modify the signature. Submit programatically. Check that submission fails

mantariksh
mantariksh approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, lgtm otherwise

src/app/utils/field-validation/validators/mobileNoValidator.ts Outdated Show resolved Hide resolved
@tshuli @mantariksh
refactor: answer
0e69898 
Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
@tshuli tshuli merged commit a24f7c7 into release-4.58.0 Feb 16, 2021
@tshuli tshuli mentioned this pull request Feb 17, 2021
Closed
@karrui karrui deleted the release-4.58.1-hotfix-mobile-signature branch April 21, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tshuli @mantariksh