refactor: convert frontend MyInfo services to TypeScript #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
force-pushed
the
ref/frontend-myinfo-ts-services
branch
from
ea2d436
to
97b7c1d
Compare
|
going to add frontend tests before requesting review! |
karrui
reviewed
Feb 24, 2021
src/public/modules/forms/base/directives/submit-form.directive.js
Outdated
Show resolved
Hide resolved
karrui
reviewed
Feb 24, 2021
mantariksh
force-pushed
the
ref/frontend-myinfo-ts-services
branch
from
97b7c1d
to
dd1219a
Compare
mantariksh
force-pushed
the
ref/frontend-myinfo-ts-services
branch
from
dd1219a
to
fafcaa9
Compare
liangyuanruo
approved these changes
Mar 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the recently created MyInfo services in the frontend to TypeScript.