Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert url loader #125

Merged
merged 2 commits into from
Aug 12, 2020
Merged

fix: Revert url loader #125

merged 2 commits into from
Aug 12, 2020

Conversation

arshadali172
Copy link
Contributor

Before

image

After

image

@arshadali172 arshadali172 changed the title Revert url loader Fix: Revert url loader Aug 12, 2020
@arshadali172 arshadali172 changed the title Fix: Revert url loader fix: Revert url loader Aug 12, 2020
karrui
karrui approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arshadali172 arshadali172 merged commit e081673 into release-4.30.3 Aug 12, 2020
@liangyuanruo liangyuanruo deleted the revert-url-loader branch September 2, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arshadali172 @karrui @mantariksh