-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): write FieldVerificationService in TypeScript #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with new FieldVerificationService
axios returns errors as AxiosErrors, will need to extract out the error response text to make it behave the same way as the previous implementation
mantariksh
reviewed
Mar 3, 2021
src/public/modules/forms/base/components/verifiable-field.client.component.js
Outdated
Show resolved
Hide resolved
src/public/modules/forms/base/components/verifiable-field.client.component.js
Outdated
Show resolved
Hide resolved
src/public/modules/forms/base/directives/submit-form.directive.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
…vsg/FormSG into feat/fe-verifn-service-ts
# Conflicts: # src/public/modules/forms/base/directives/submit-form.directive.js
mantariksh
approved these changes
Mar 3, 2021
karrui
commented
Mar 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR migrates the old
verification.client.factory
Angularjs module to FieldVerificationService in TypeScript.Solution
Features:
verification.client.factory
withFieldVerificationService
Tests
Manual tests
POST /transaction
should return an empty object{}
POST /transaction
should return an object with expiry and transaction id.