-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: convert mail and sms services into neverthrown variants #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update tests
Directly use refactored function from MailService
test was failing due to old code using await syntax (and thus does not need a resolved value), and the new code uses neverthrow#andThen, which requires a promise to continue
karrui
changed the title
wip: convert mail and sms services into neverthrown variants
ref: convert mail and sms services into neverthrown variants
Mar 11, 2021
mantariksh
reviewed
Mar 11, 2021
mantariksh
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the way
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR improves the type safety and error handling of
MailService
andSmsService
by refactoring the exposed functions into theirneverthrow
n variants.Sorry for the huge PR, they were pretty interconnected; I tried to make the commits as concise as possible for ease of reviewing commit-by-commit.
Closes #1260
Solution
Improvements:
MailService
functions to neverthrown variantSmsService
functions to neverthrown variantVerificationService
SmsSendError
for logging purposesMailSendError
for logging purposesTests
For mail service
For sms service