Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: automate dependency upgrades using mergify #1424

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Mar 22, 2021

Problem

This project has over 200 dependencies, resulting in around 5-10 dependency upgrades a day. All these upgrades are currently manually approved and merged by engineers, which requires time and effort.

Solution

Use mergify to merge dependabot PRs which pass tests, except major version changes. Refer to docs to verify the correctness of the regex.

This screenshot from the Mergify config editor demonstrates that PR #1417 (patch version change, CI passing) would be automatically merged using this config:
Screenshot 2021-03-22 at 5 03 46 PM

Whereas this screenshot shows that PR #1422 (patch version change, CI failing) would not be merged:
image

And this screenshot shows that PR #1423 (major version change, CI passing) would not be merged:
image

Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative. Is there a way to automatically merge only when it is not a major version change? I sometimes find that it's prudent to take a look at the changelog when it could potentially be breaking.

@mantariksh
Copy link
Contributor Author

mantariksh commented Mar 22, 2021

Is there a way to automatically merge only when it is not a major version change?

@liangyuanruo Great idea, added and updated the screenshots from the config editor

@liangyuanruo liangyuanruo merged commit bf8371c into develop Mar 22, 2021
@liangyuanruo liangyuanruo deleted the build/mergify branch March 22, 2021 09:42
@karrui karrui mentioned this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants