Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove isTemplate validation on duplicate template api #1432

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Mar 23, 2021

Problem

Remove dangling unused key in Joi validation for /adminform/copy endpoint.
Checked via Cloudwatch logging and no instances of the isTemplate key being sent for the past month.

Closes #792

@liangyuanruo liangyuanruo merged commit 32f34e3 into develop Mar 23, 2021
@liangyuanruo liangyuanruo deleted the feat/remove-istemplate branch March 23, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove isTemplate validation on duplicate template API after all clients are updated
2 participants