feat(feature-manager): remove GoogleAnalytics feature #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e2e tests are doing their job, need to update them to use full-env |
|
actually I think I'll add the test commit separately |
mantariksh
force-pushed
the
remove-fm/google-analytics
branch
from
2ca7dea
to
c1797a3
Compare
karrui
approved these changes
Jun 10, 2021
mantariksh
force-pushed
the
remove-fm/google-analytics
branch
2 times, most recently
from
7757ce7
to
1fa9625
Compare
mantariksh
force-pushed
the
remove-fm/google-analytics
branch
from
1fa9625
to
80a06d8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #1842
Solution
Removes the
GoogleAnalyticsfeature from the feature manager.Breaking Changes
Deploy Notes
Note that the server can no longer start up successfully without the presence of the
GA_TRACKING_IDenvironment variable.A mock default for
GA_TRACKING_IDhas been adding indocker-compose.ymlto minimise disruption to developers. However, this means that this env var has to be removed fromdocker-compose.ymlin order to use Google Analytics on localhost. This tradeoff was made because developers rarely need to use GA in localhost, but always need to have their dev environment configured correctly.Tests
The end-to-end tests used to distinguish between "basic environment" and "full environment" tests to ensure that the open-source version of the product (without any optional env vars) works correctly. Since all env vars are now required and the server now breaks without them, this distinction was removed in 2ca7dea.