feat(react): allow markdown in FormLabel description, allow as
prop in custom Link component
#2794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some designs in Figma contains Form label descriptions with links. This seemed easier to achieve in markdown and thus the ability for markdown in FormLabel.Description is implemented.
See
Whilst doing so, realize the
Link
component cannot be re-morphed into another type using theas
prop which is a common in ChakraUI. This commit was cherry picked from commit 22faa66 in #2683.Solution
Features:
useMarkdown
prop in FormLabel.Description anduseMarkdownForDescription
prop in the main FormLabel component to allow markdown in form label descriptions.as
prop in custom Link componentBefore & After Screenshots
New story added in Storybook for markdown in form label description.