Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greater clarity for available features, project roadmap and deployment instructions; disable E2E tests #301

Merged
merged 20 commits into from
Sep 9, 2020
Merged

Greater clarity for available features, project roadmap and deployment instructions; disable E2E tests #301

merged 20 commits into from
Sep 9, 2020

Commits on Sep 8, 2020

  1. fix(readme): mailto syntax

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6d6fd7a View commit details
    Browse the repository at this point in the history

  2. doc(contributing): instructions for security findings; minor touchups

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    37fb793 View commit details
    Browse the repository at this point in the history

  3. doc(readme): instructions and clarifications on scope of contributions

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7b7d1ad View commit details
    Browse the repository at this point in the history

  4. doc(readme): refactor running locally statement

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1b792ec View commit details
    Browse the repository at this point in the history

  5. doc(readme): clarify product roadmap

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1d6938f View commit details
    Browse the repository at this point in the history

  6. doc(readme): include corppass

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0be4750 View commit details
    Browse the repository at this point in the history

  7. doc(deployment): organise infrastructure employed, markdown linting

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    86fea26 View commit details
    Browse the repository at this point in the history

  8. doc: Update CONTRIBUTING.md 

    Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
    @r00dgirl @mantariksh @liangyuanruo
    2 people authored and liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1150e68 View commit details
    Browse the repository at this point in the history

  9. doc: Update CONTRIBUTING.md 

    Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
    @r00dgirl @mantariksh @liangyuanruo
    2 people authored and liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f39536a View commit details
    Browse the repository at this point in the history

  10. doc: Update CONTRIBUTING.md 

    Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
    @r00dgirl @mantariksh @liangyuanruo
    2 people authored and liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    644c00c View commit details
    Browse the repository at this point in the history

  11. doc: Update README.md 

    Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
    @r00dgirl @mantariksh @liangyuanruo
    2 people authored and liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    db00fa8 View commit details
    Browse the repository at this point in the history

  12. doc: Update docs/DEPLOYMENT_SETUP.md grammar 

    Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
    @liangyuanruo @mantariksh
    liangyuanruo and mantariksh committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    9ca3303 View commit details
    Browse the repository at this point in the history

  13. doc: apply suggestions from code review 

    * file rename to src/server.ts
* hyperlinks to aboutus pages for SP/CP/MyInfo

Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
    @liangyuanruo @mantariksh
    liangyuanruo and mantariksh committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8bc21b3 View commit details
    Browse the repository at this point in the history

  14. doc: clarify SMS deployment

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    ebb63d9 View commit details
    Browse the repository at this point in the history

  15. doc(deployment): default NODE_ENV is production

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    f878b4c View commit details
    Browse the repository at this point in the history

  16. doc(deployment): clarify SESSION_SECRET variable

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c7c5c0d View commit details
    Browse the repository at this point in the history

  17. doc(attachments): add ATTACHMENT_S3_BUCKET in deployment setup instru… 

    …ctions
    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    63cf888 View commit details
    Browse the repository at this point in the history

  18. Apply Sonjia's suggestions from code review 

    Co-authored-by: syan-syan <55272802+syan-syan@users.noreply.github.com>
    @liangyuanruo @r00dgirl
    liangyuanruo and r00dgirl committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3be6bc3 View commit details
    Browse the repository at this point in the history

  19. docs: remove duplicate LOGO_S3_BUCKET

    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    ccfb1f0 View commit details
    Browse the repository at this point in the history

  20. refactor(e2e)!: disable end-to-end tests 

    E2E tests are disabled due to apparent race condition when evaluating
webhooks in Travis. Link to example:

https://travis-ci.com/github/opengovsg/FormSG/builds/183369046
    @liangyuanruo
    liangyuanruo committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    03ea238 View commit details
    Browse the repository at this point in the history