Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(proxy): do not override X-Forwarded-Proto headers #304

Merged
merged 1 commit into from
Sep 10, 2020
Merged

refactor(proxy): do not override X-Forwarded-Proto headers #304

merged 1 commit into from
Sep 10, 2020

Conversation

liangyuanruo
Copy link
Contributor

arshadali172
arshadali172 suggested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@arshadali172 arshadali172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it better to explicitly set the number of hops as 1?

@liangyuanruo
Copy link
Contributor Author

liangyuanruo commented Sep 9, 2020 •
edited
Loading

isn't it better to explicitly set the number of hops as 1?

It is simpler to set it to true to accommodate the general case where the left-most X-Forwarded-For header is the client IP address, since we do not need to make assumptions on the number of proxies for open source users. It is also the first setting documented in Express.

@arshadali172 arshadali172 merged commit 2cd667b into develop Sep 10, 2020
@liangyuanruo liangyuanruo deleted the refactor/proxy branch September 10, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arshadali172 arshadali172 arshadali172 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liangyuanruo @arshadali172