Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update copy for email fields, intranet, privacy #321

Merged
merged 4 commits into from
Sep 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Enable Captcha
<i
class="glyphicon glyphicon-question-sign"
uib-tooltip="Captcha does not work on the Intranet, and should be disabled if users submits form on Intranet."
uib-tooltip="Picture selection to prove respondent is human and prevent spam submission."
tooltip-trigger="'click mouseenter'"
></i>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function verifySecretKeyDirective(FormSgSdk) {
case 'reader-abort':
return 'File could not be read. Please try again.'
case 'invalid-key':
return 'Form activation unsuccessful. Secret Key error, please try again.'
return 'Secret Key error. Please try again.'
default:
return 'An error occurred. Please try again.'
}
Expand Down
19 changes: 14 additions & 5 deletions src/public/modules/forms/admin/views/edit-fields.client.modal.html
Original file line number Diff line number Diff line change
Expand Up @@ -593,11 +593,20 @@ <h2 class="modal-title">
<div class="row" ng-if="vm.field.fieldType === 'email'">
<div class="toggle-option">
<div class="col-xs-8 label-custom label-medium">
Email confirmation<i
class="glyphicon glyphicon-question-sign"
uib-tooltip="Recipients will receive an email confirmation with their submission reference number, and a customised message from you."
tooltip-trigger="'click mouseenter'"
></i>
Email confirmation<span ng-switch="vm.myform.responseMode">
<i
ng-switch-when="encrypt"
class="glyphicon glyphicon-question-sign"
uib-tooltip="Customised email acknowledgement to the respondent."
tooltip-trigger="'click mouseenter'"
></i>
<i
ng-switch-default
class="glyphicon glyphicon-question-sign"
uib-tooltip="Recipients will receive an email confirmation with their submission reference number, and a customised message from you."
tooltip-trigger="'click mouseenter'"
></i>
</span>
</div>
<div class="col-xs-4 field-input">
<label
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,22 +59,6 @@
><i class="bx bx-loader bx-spin bx-lg"></i
></span>
</button>
<div feature-toggle feature-name="captcha">
<div
id="preview-captcha-notice"
class="alert-info alert-custom"
ng-if="form.isPreview && form.hasCaptcha"
>
<i class="bx bx-exclamation bx-md icon-spacing"></i>
<div class="alert-msg">
You are submitting a form with
<strong>captcha enabled</strong> while in
<strong>preview mode</strong>. Captcha is not supported on the
intranet. Respondents on intranet may not be able to submit this
form.
</div>
</div>
</div>
</div>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function captchaService($window, vcRecaptchaService, Toastr) {
vcRecaptchaService.execute(this.widgetId)
} catch (err) {
// If https://www.google.com/recaptcha/api.js?onload=vcRecaptchaApiLoaded&render=explicit
// could not loaded (eg, while on intranet). vcRecaptchaService throws an error.
// could not loaded. vcRecaptchaService throws an error.
Toastr.error(
'Please ensure you have internet connectivity for CAPTCHA to load on this form.',
)
Expand Down
35 changes: 29 additions & 6 deletions src/public/modules/users/views/static/privacy.client.view.html
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ <h2 class="hidden-sm hidden-md hidden-lg static-view-header">
</p>

<p>
4. safeguard your personal data, all electronic storage and transmission
of personal data is secured with appropriate security technologies.
4. To safeguard your personal data, all electronic storage and
transmission of personal data is secured with appropriate security
technologies.
</p>

<p>
Expand All @@ -156,18 +157,40 @@ <h2 class="hidden-sm hidden-md hidden-lg static-view-header">
consult the privacy notices of those sites.
</p>

<p>7. Please contact formsg@tech.gov.sg if you:</p>
<p>7. Please see the Annex for additional terms/notices.</p>

<p>8. Please contact formsg@tech.gov.sg if you:</p>
<ul>
<li>
7.1. have any enquires or feedback on our data protection policies and
8.1. have any enquires or feedback on our data protection policies and
procedures; or
</li>
<li>
7.2. need more information on or access to data which you have provided
8.2. need more information on or access to data which you have provided
to us in the past.
</li>
</ul>
<br /><br /><br />
<center>This Privacy Policy is dated 1 Jun 2020.</center>
<center>This Privacy Policy is dated 15 Sep 2020.</center>
<h1 class="hidden-xs static-view-header">Annex</h1>
<h2 class="hidden-sm hidden-md hidden-lg static-view-header">Annex</h2>
<p><strong>Name of Service:</strong> form.gov.sg</p>
<p>
1. If you are a form creator, please note that GovTech will collect your
email address and other contact details. As GovTech may collect, store
and/or process data requested by you from the form respondents, please
ensure that your privacy policy adequately provides the respondents with
notice of the same and that your privacy policy complies with applicable
rules/laws.
</p>
<p>
2. If you are a form respondent, please note that GovTech may collect,
store and/or process data that you submit in accordance with this Privacy
Policy (which applies in addition to the privacy policy of the form
creator) and disclose the data to the form creator, or process the data
for the form creator. If you have questions on the use of your data,
please consult the privacy policy of the form creator or contact the form
creator directly.
</p>
</div>
</section>