feat: add billing module to handle /billing endpoints #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
karrui
changed the title
karrui
changed the title
# Conflicts: # src/config/feature-manager/util/FeatureManager.class.ts
4 tasks
liangyuanruo
reviewed
Oct 5, 2020
Comment on lines
+61
to
+63
| export const isUserInSession = (req: Request): boolean => { | ||
| return !!req.session?.user | ||
| } |
There was a problem hiding this comment.
at some point we should also save the user ID and the user object into session, so that we can migrate off the user object at our convenience.
# Conflicts: # src/app/controllers/admin-console.server.controller.js # src/loaders/express/index.ts
# Conflicts: # src/app/controllers/admin-console.server.controller.js # src/app/factories/spcp-myinfo.factory.js
mantariksh
approved these changes
Oct 12, 2020
| endOfMonth.toDate(), | ||
| ) | ||
|
|
||
| if (loginStatsResult.isErr()) { |
There was a problem hiding this comment.
the original code has a loginStatsResult.isOk() && !loginStatsResult.value case as well, is there any chance of that happening?
There was a problem hiding this comment.
no, aggregate always returns an array; but the array can be empty
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃棐 This PR is complete with the exception of integration tests for BillingRouter, see note below in the test section.
Problem
This PR extracts out billing related functions in various controllers and services and reorganises them into the
modules/billingdirectory.Related to #144
Solution
Features:
aggregateLoginStatsmethod toLoginModelso it can be easily used by servicesBillingService#getSpLoginStatsfunction to retrieve SingPass login statisticsBillingFactoryto return correct function handler depending on whetherspcp-myinfofeature is enabled in the Feature ManagerBillingControllercontroller handler for/billingroute/billingroute with the newBillingRouterTests
This will be delayed until #371 is merged in as that contains code for generated an authenticated session (or should I cherry pick the appropriate commits? Scared that will scare ppl off with the commit size again)