Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use comments for PR template guiding questions #420

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Oct 6, 2020

Problem

This PR allows for contributors to not have to manually delete lines for a cleaner PR, and just insert wherever possible. The remaining text is the entirety of the template for example's sake.

Solution

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

Deploy Notes

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

this allows us to not have to manually delete lines for a cleaner PR, and just insert wherever possible
@liangyuanruo liangyuanruo merged commit ff7466e into develop Oct 6, 2020
@liangyuanruo liangyuanruo deleted the chore/update-pr-template branch October 6, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants