refactor: convert remaining res.send to res.json #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
reviewed
Oct 12, 2020
mantariksh
force-pushed
the
refactor/res-json-3
branch
from
d5986ad
to
ee12f24
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Usage of
res.sendcreates the risk of HTML injection attacks if not used with care. Usingres.jsonis better practice.Solution
This PR covers all remaining cases in the codebase where
res.sendis used. All these cases pass strings intores.send, hence these changes are backwards-compatible. The client sees the same response except with theContent-Typeheader changed fromtext/htmltoapplication/json.