Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate that webhook does not point back to app #475

Merged
merged 4 commits into from
Oct 15, 2020
Merged

feat: validate that webhook does not point back to app #475

merged 4 commits into from
Oct 15, 2020

Conversation

mantariksh
Copy link
Contributor

Problem

Users are allowed to enter webhook URLs which point back to the app, which results in 404 errors when our servers POST back to themselves.

Solution

Validate that the webhook URL domain is not the same as the app URL.

Screenshots

image

liangyuanruo
liangyuanruo suggested changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think using the inbuilt NodeJS URL object for parsing would be valuable here.

@liangyuanruo liangyuanruo merged commit f1b42da into develop Oct 15, 2020
@liangyuanruo liangyuanruo deleted the feat/validate-webhook-app-url branch October 15, 2020 12:31
@tshuli tshuli mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mantariksh @liangyuanruo