Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly show decrypt progress modal after 3 seconds when downloading storage mode responses #476

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Oct 16, 2020

Problem

Missed adding vm... seems like that came back to bite us in the butt.

Solution

Bug Fixes:

  • fix: correctly show decrypt progress modal when downloading storage mode responses

Tests

For local testing, I've set the timeout before the modal appears to 0 milliseconds (i.e instantly).
For release testing, a test form with >100k responses should be used so the decrypting takes more than 3 seconds.

  • Decrypt modal should show up after 3 seconds if downloading storage mode responses has not completed in that timeframe.

Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karrui karrui merged commit 3f798c9 into develop Oct 16, 2020
@karrui karrui deleted the fix/show-decrypt-progress-modal branch October 16, 2020 02:29
@tshuli tshuli mentioned this pull request Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants