-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade sgid sdk #6584
Merged
Merged
feat: upgrade sgid sdk #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this @kschiew ! Generally LGTM with just a few small comments
justynoh
force-pushed
the
feat/upgrade_sgid_sdk
branch
from
August 18, 2023 04:34
ccd1dde
to
ad06fe7
Compare
justynoh
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
sgID did a major release for its TypeScript SDK recently and will deprecate support for v1 SDK (which is currently used by FormSG) by the end of the year.
Solution
sgid-client
to v2.v4.x
which is compatible to v2 ofsgid-client
.Breaking Changes
sgid-client
version is>= 2.0.0
.Improvements:
Tests
code_verifier
cookie is missing./ogp-login
route. This should work correctly.Deploy Notes
New environment variables:
SGID_HOSTNAME
indocker-compose.yml
: updated accordingly to Mockpass' changes. No changes required for staging/prod env vars.New dependencies:
@opengovsg/sgid-client
: Bumped from^1.0.4
tov2.0.0
.mockpass
: Bumped fromv3.1.3
tov4.0.4
.