fix: Myinfo Child DOB

[wanlingt]

Problem

Myinfo Child DOB is not showing up in the correct format in the frontend.

Solution

When the Myinfo Child DOB value is set, convert the date from the formats 'yyyy-MM-dd' to 'dd/MM/yyyy'.

The way the Myinfo Child values are processed is different from normal Myinfo fields. For example, for normal Myinfo fields, the preview of the field is distinct from the value of the field that's submitted. However, for Myinfo child fields, the value shown in the field is what's submitted. Hence, in this case, the formatting takes place in 2 areas:

1. In the frontend (ChildrenCompoundField) before the field value is set
2. In the backend, before the value gets hashed (myinfo.util.ts)

(TODO for the future - Ideally, the Myinfo child values will be processed in the same way as the normal Myinfo fields)

Details

• Created a shared function to format Myinfo dates (formatMyinfoDate)

Breaking Changes

• No - this PR is backwards compatible

Before & After Screenshots

(Look at the Child DOB field)

BEFORE:

AFTER:

Tests

1. Happy path test

• On a Myinfo form, create a child field with the DOB.
• Fill in the form (Staging Myinfo accounts here)
• The DOB should be in the format 'dd/MM/yyyy' on the form UI.
• Submit the form
• Check the email submission - the DOB for the child's field should also be in the same format.

2. Regression test

• On a Myinfo form, add the (non-child) Myinfo fields DOB (already has existing Myinfo data) and Marriage Date (has no existing Myinfo data)
• The dates should be in the format 'dd/MM/yyyy' on the form UI.
• Submit the form
• Check the email submission - the dates should show up correctly

[foochifa]

Generally LGTM! Thanks for locating the problem @wanlingt

[foochifa]

Approving again haha LGTM Thanks @wanlingt