Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.73.0 #6657

Merged
merged 5 commits into from
Aug 24, 2023
Merged

build: release v6.73.0 #6657

merged 5 commits into from
Aug 24, 2023

Conversation

LinHuiqing
Copy link
Contributor

@LinHuiqing LinHuiqing commented Aug 24, 2023

New

  • fix: add specific payment descriptions logic for payment types #6651
  • fix: failed ensures should block submission #6654
  • build: merge v6.72.0 into develop #6650
  • fix: address should be lower case #6653
  • build: release v6.72.0 #6649
  • chore: bump version to v6.73.0 d190a63

Dependencies

Dev-Dependencies

Tests

fix: add specific payment descriptions logic for payment types #6651

@LinHuiqing @foochifa
Hint: use this url to get the payment item on stripe dashboard quickly https://dashboard.stripe.com/test/connect/accounts/<acct_id>/payments/<pi_id>

Variable Payment Form

  • Create a variable payment form, set the name as "tis but a variable", and description as "description"
    • Complete making a payment
    • Ensure that payment summary displays "tis but a variable"
    • Ensure that description on Stripe Payment item is "tis but a variable"

Products Payment Form

  • Create a Products payment form, create two products
    • Set first item as "item1", "description1" for name and description, and multiple quantity as "OFF"
    • Set second item as "item2", "description2" for name and description, and multiple quantity of 1 to 99
    • Set payment settings as multiple products
    • Complete making a payment with two selected items, and 2nd item to be quantity 10
    • Ensure that payment summary displays "item1 x 1, item2 x 10"
    • Ensure that description on Stripe Payment item is "item1 x 1, item2 x 10"

fix: failed ensures should block submission #6654

@KenLSM
Check that storage mode submissions will be gated by ensures.

  • ensureIsPublicForm:
    • Go to a public form.
    • Close the form on the admin portal.
    • Make a submission. Submission should not succeed.
      • Error should be shown to client.
      • New submission should not show up on DB
  • ensureValidCaptcha:
    • Go to a public form with captcha disabled.
    • Enable captcha on the admin portal.
    • Make a submission. Submission should not succeed.
      • Error should be shown to client.
      • New submission should not show up on DB
  • ensureFormWithinSubmissionLimits:
    • Go to a public form with a submission limit. The form should still be open at this point.
    • On the DB, edit the submission limit so that it is less than or equal to the number of existing submissions.
    • Make a submission. Submission should not succeed.
      • Error should be shown to client.
      • New submission should not show up on DB

fix: address should be lower case #6653

  • Ensure that Email address in payment preview is title case

KenLSM and others added 5 commits August 23, 2023 13:22
build: merge v6.72.0 into develop
* fix: failed ensures should block submission

* refactor: return guard clause
* fix: add specific payment descriptions logic for payment types

* refactor: move function to utils

* chore: add tests

* refactor: add default case and exhaustive checks

* chore: better variable naming
@LinHuiqing LinHuiqing temporarily deployed to staging August 24, 2023 06:29 — with GitHub Actions Inactive
@KenLSM KenLSM merged commit ab4001f into release-al2 Aug 24, 2023
69 of 71 checks passed
@KenLSM KenLSM deleted the release_v6.73.0 branch August 24, 2023 07:05
@KenLSM KenLSM mentioned this pull request Aug 31, 2023
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants