fix: prevent generation of charts if number of responses exceed limit #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanlingt
approved these changes
Nov 30, 2023
FRM-1550 Prevent generation of charts if number of responses exceed limit
Description Problem Charts is lagging for forms with a large number of responses. The current limitation of 1000 responses is limited at the DB query level and although responses will not be computed for charts, they will still be decrypted, which could result in the lagginess. https://opengovproducts.slack.com/archives/CKHLS3W3X/p1701252497787879 Solution Show empty charts and prevent decryption if total response count exceeds a limit configured on growthbook. |
sebastianwzq
had a problem deploying
to
staging
GitHub Actions
Failure
sebastianwzq
had a problem deploying
to
staging
GitHub Actions
Failure
sebastianwzq
had a problem deploying
to
staging
GitHub Actions
Failure
sebastianwzq
commented
Nov 30, 2023
| @@ -9,7 +9,7 @@ RUN chown 1001:1001 /mongodb_data | |||
| ENV CHROMIUM_BIN=/usr/bin/chromium-browser | |||
| ENV NODE_ENV=development | |||
| # --openssl-legacy-provider flag | |||
| # A breaking change in the SSL provider was introduced in node 17. This caused | |||
There was a problem hiding this comment.
Didn't make any whitespace changes not sure why they are reflected. Linting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Charts is lagging for forms with a large number of responses. The current limitation of 1000 responses is limited at the DB query level and although responses will not be computed for charts, they will still be decrypted, which could result in the lagginess.
Fixed another issue where chromium version upgrades are causing deployment to fail.
Closes FRM-1550
Solution
Show empty charts and prevent decryption if total response count exceeds a configured limit.
[Update] Updating Chromium as the Chromium version currently available on alpine3.18 is 119.0.6045.159-r0
Breaking Changes
Before & After Screenshots
BEFORE:
AFTER:
Deployment
charts-max-response-countto Growthbook and set it to 1000Tests