Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.95.0 #6956

Merged
merged 5 commits into from
Dec 11, 2023
Merged

build: release v6.95.0 #6956

merged 5 commits into from
Dec 11, 2023

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Dec 11, 2023

New

  • fix: show error toast if error is not a network error #6950
  • fix: fix attachment file size check differences between FE and BE #6955
  • build: merge release v6.94.0 into develop #6954
  • build: release v6.94.0 #6953

Dependencies

  • build(deps): [Snyk] Security upgrade @opengovsg/formsg-sdk from 0.10.0 to 0.11.0 #6951

Dev-Dependencies

Tests

fix: show error toast if error is not a network error #6950

@KenLSM

  • Open a storage mode form's public form page
  • As the form admin, close the form
  • Click the submit form button
  • You should see the error message "This form has been taken down. For assistance, please contact the person who asked you to fill in this form." instead of a Non-2XX response in the error toast

fix: fix attachment file size check differences between FE and BE #6955

@KenLSM

  • create email mode form with attachment field of 1mb limit
  • run mkfile 1000000 test.txt to create a 1mb file (note that formsg uses 1mb = 1000000 instead of 1024*1024)
  • upload attachment, you should not encounter any errors

justynoh and others added 5 commits December 7, 2023 23:55
build: merge release v6.94.0 into develop
…0 to 0.11.0 (#6951)

fix: frontend/package.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-AXIOS-6032459

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
)

* fix: fix file size check differences between FE and BE

* fix: change wrong commit
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@KenLSM KenLSM merged commit 56af23c into release-al2 Dec 11, 2023
52 of 54 checks passed
@KenLSM KenLSM deleted the release_v6.95.0 branch December 11, 2023 06:20
@KenLSM KenLSM mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants