fix(mrf): form duplication with MRF #6985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We broke form duplication and use-template flows by introducing multi-respondent forms into production. This PR aims to fix the issue with duplication.
Closes FRM-1581
Solution
Requests never made it to the backend because of a response mode check
responseMode === FormResponseMode.Encryptin the relevant providers (duplicate form provider, template form provider). This PR thus updates the relevant mutations to handle storage mode and MRF form duplications, and addsFormResponseMode.Multirespondentto the response mode check.Breaking Changes
Screenshots
Screen.Recording.2023-12-28.at.2.28.34.PM.mov
Tests
Regression tests
New tests