fix: add patch to feed default ValidationOptions on table shorttext #7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
reviewed
Jan 23, 2024
Comment on lines
+609
to
+610
| customVal: null, | ||
| selectedValidation: null, |
There was a problem hiding this comment.
I'm wondering if we should add the prefill properties too, just for db consistency's sake
There was a problem hiding this comment.
Hm those are marked as optional on types. But if we look at inheritance it should be populated.
Both are correct. I in favour of keeping it as simple as possible.
wanlingt
reviewed
Jan 23, 2024
| newField: FieldUpdateDto, | ||
| ) => { | ||
| if (newField.fieldType === BasicField.Table) { | ||
| const defaultValidationOptions = { |
There was a problem hiding this comment.
Suggested change
| const defaultValidationOptions = { | |
| const defaultValidationOptions: TextValidationOptions = { |
(import TextValidationOptions from '../../../../../shared/types')
There was a problem hiding this comment.
Makes sense. Added in b8cb466
wanlingt
approved these changes
Jan 23, 2024
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to this issue on Mongoose 6.x, discriminated fields doesn't respect inherited defaults.
This currently affects our Table field where a
dropdowncolumn is updated toshortText. This would then be updated into the DB without aValidationOptionsfield. Consequently, code that referencescolumn.ValidationOptions.*would throw an error as the object isundefined.Note: Inserting a new
shortTextcolumn uses the helper function that contains theValidationOptionsfield, thus not affected by this change.Solution
Add a patch that checks for shortText and provide a defaulted
ValidationOptionsobject to it.Tests
Bug fix tests, reproduction steps