Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mrf): remove any response limits for MRF #7214

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Mar 27, 2024

Problem

If a user already sets a response limit and duplicates the form as an MRF, the response limit would be set but is disabled and the user will not be able to turn off the response limit:

image

Closes FRM-1698

Solution

If a user duplicates a form to MRF that was originally on email/storage mode, and a response limit has been set, the new MRF form should have it's response limit switched off.

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

AFTER:
image

Manual Tests

  • Create a form on email or storage mode
  • Switch on the response limit (using the toggle) under Settings
  • Duplicate the form which has a response limit set to an MRF
  • Check that within the duplicated MRF, the response limit under Settings is switched off and the toggle disabled (hence there is no way for the response limit to be on for MRFs)

Copy link

linear bot commented Mar 27, 2024

@kathleenkhy kathleenkhy merged commit b1a7790 into develop Mar 28, 2024
21 checks passed
@kathleenkhy kathleenkhy deleted the fix/disable-response-limit-mrf branch March 28, 2024 05:26
@KenLSM KenLSM mentioned this pull request Apr 2, 2024
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants