Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move override code closer to other overrides #7216

Merged
merged 2 commits into from
Mar 28, 2024
Merged

refactor: move override code closer to other overrides #7216

merged 2 commits into from
Mar 28, 2024
+2 −7

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Mar 28, 2024

Problem

There's already a function that keeps all the duplication exclusion rules. We should use that.

Thanks @justynoh for highlighting an even better way.

Solution

Move override statement into processDuplicateOverrideProps function.

@KenLSM KenLSM requested a review from kathleenkhy March 28, 2024 06:57
kathleenkhy
kathleenkhy approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@kathleenkhy kathleenkhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 lgtm!!

@KenLSM KenLSM merged commit f900768 into develop Mar 28, 2024
21 checks passed
@KenLSM KenLSM deleted the refactor/mrf-submission-override branch March 28, 2024 07:56
@KenLSM KenLSM mentioned this pull request Apr 2, 2024
Merged
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathleenkhy kathleenkhy kathleenkhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KenLSM @kathleenkhy