Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add exhaustive checks, use answerArray for arrays #7244

Merged
merged 1 commit into from
Apr 4, 2024
Merged

refactor: add exhaustive checks, use answerArray for arrays #7244

merged 1 commit into from
Apr 4, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 4, 2024 •
edited
Loading

Problem

Following the specs for sample field responses, we should return answer: string for single values, and answerArray: [] for multiple values.

Solution

Switch to use answerArray for checkbox and table

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression

  • Create a form
  • Open the form
  • Add Checkbox Field
  • Go to /api/v3/forms/:formid/sample-submission
  • Ensure that page returns JSON value
  • Ensure that checkbox field returns []-like

@KenLSM KenLSM marked this pull request as ready for review April 4, 2024 07:31
@KenLSM KenLSM merged commit a6ae1e1 into develop Apr 4, 2024
40 checks passed
@KenLSM KenLSM deleted the fix/sample-submission-integration branch April 4, 2024 09:44
@KenLSM KenLSM mentioned this pull request Apr 8, 2024
Merged
9 tasks
@KenLSM KenLSM mentioned this pull request Apr 22, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathleenkhy kathleenkhy kathleenkhy approved these changes

@justynoh justynoh Awaiting requested review from justynoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KenLSM @kathleenkhy