Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move react-dev-inspector to frontend/package.json #7245

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

kathleenkhy
Copy link
Contributor

Problem

react-dev-inspector was situated in ./package.json which resulted in local environment facing errors (screenshot below).

Why was react-dev-inspector suspected?

  1. It was the code that referenced react highlighted in the stacktrace, and was installed in the wrong package.json. It should be in frontend/package.json.
  2. We also added types/react@18 that might have tricked npm to assume that there was a legit react on the root-level node_modules (edited)

image

Solution

To move react-dev-inspector to frontend/package.json instead. With this, forms should be able to be rendered properly on local.

Breaking Changes

  • No - this PR is backwards compatible

@kathleenkhy kathleenkhy requested a review from KenLSM April 4, 2024 10:08
@@ -49,6 +49,7 @@
"react": "^17.0.2",
"react-beautiful-dnd": "^13.1.0",
"react-csv": "^2.2.2",
"react-dev-inspector": "^2.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is also bumped 🤔
Is it compatible with our react? I saw that it was using react@18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended version back to 1.8.6

@KenLSM KenLSM merged commit 916f1b3 into develop Apr 5, 2024
20 of 22 checks passed
@KenLSM KenLSM deleted the chore/move-dev-inspector-to-frontend branch April 5, 2024 02:14
@KenLSM KenLSM mentioned this pull request Apr 8, 2024
9 tasks
@KenLSM KenLSM mentioned this pull request Apr 22, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants