Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mrf): webhook be validation #7247

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix(mrf): webhook be validation #7247

merged 2 commits into from
Apr 5, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 5, 2024 •
edited
Loading

Problem

Admins cannot edit their forms, nor self-help to remove the webhooks after connecting to Plumber

  1. MRF doesn’t support webhooks.
  2. On FormFE, MRF will not allow admins to set webhooks
  3. On FormBE, webhooks setting update can still be done programmatically (i.e., through plumber)

Solution

Block on BE to prevent users from reaching this state.

Returns MalformedParametersError if populating webhook is attempted

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression

  • create an MRF
  • run a curl command to update the webhooks[1]

[1] take reference from a webhook update to a storage form and swap out the formid

@KenLSM KenLSM requested a review from kathleenkhy April 5, 2024 03:38
@KenLSM KenLSM changed the base branch from develop to release-al2 April 5, 2024 03:38
kathleenkhy
kathleenkhy approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@kathleenkhy kathleenkhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KenLSM KenLSM force-pushed the fix/mrf-webhook-be-validation branch from cad8d9c to c9df822 Compare April 5, 2024 05:18
@KenLSM
fix: add check to block webhooks updates on mrf
71ab0c5 
fix: switch form to original form

test: add test cases for mrf webhook blocks

chore: update comments for clarity
@KenLSM KenLSM force-pushed the fix/mrf-webhook-be-validation branch from c9df822 to 71ab0c5 Compare April 5, 2024 05:20
@KenLSM KenLSM force-pushed the fix/mrf-webhook-be-validation branch from 1413758 to 7d127b2 Compare April 5, 2024 05:24
@KenLSM KenLSM marked this pull request as ready for review April 5, 2024 05:25
@KenLSM KenLSM merged commit 5a631f5 into release-al2 Apr 5, 2024
22 checks passed
@KenLSM KenLSM deleted the fix/mrf-webhook-be-validation branch April 5, 2024 05:48
@KenLSM KenLSM mentioned this pull request Apr 8, 2024
Merged
9 tasks
@KenLSM KenLSM mentioned this pull request Apr 22, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathleenkhy kathleenkhy kathleenkhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KenLSM @kathleenkhy