Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for truthiness of fieldname in receiver #7370

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix: check for truthiness of fieldname in receiver #7370

merged 2 commits into from
Jun 7, 2024
+21 −6

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jun 7, 2024 •
edited
Loading

Closes FRM-1733

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression
Form with attachments can be submitted
  • Create a form with attachments
  • Ensure that form can be submitted with attachments

@linear Linear
Copy link

linear bot commented Jun 7, 2024

FRM-1733 Handle missing `fieldname` in multipart content

@KenLSM KenLSM changed the title check for truthiness of fieldname in receiver fix: check for truthiness of fieldname in receiver Jun 7, 2024
@KenLSM KenLSM changed the base branch from develop to release-al2 June 7, 2024 02:42
@KenLSM KenLSM changed the base branch from release-al2 to develop June 7, 2024 02:42
@KenLSM KenLSM force-pushed the fix/capture-missing-fieldname branch from 89fe00b to 429e1e9 Compare June 7, 2024 02:43
@KenLSM KenLSM changed the base branch from develop to release-al2 June 7, 2024 02:43
g-tejas
g-tejas approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@KenLSM KenLSM force-pushed the fix/capture-missing-fieldname branch from 74375b1 to 08eba07 Compare June 7, 2024 03:08
@KenLSM KenLSM merged commit 8754489 into release-al2 Jun 7, 2024
9 of 10 checks passed
@KenLSM KenLSM deleted the fix/capture-missing-fieldname branch June 7, 2024 03:08
@g-tejas g-tejas mentioned this pull request Jun 13, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-tejas g-tejas g-tejas approved these changes

@sebastianwzq sebastianwzq Awaiting requested review from sebastianwzq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KenLSM @g-tejas