Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conditionally render sex based on timezone #7376

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

ghostleek
Copy link
Contributor

@ghostleek ghostleek commented Jun 10, 2024

Problem

Partially Closes FRM-1727

Solution

Breaking Changes

  • No - this PR is backwards compatible

Features:

  • Details ...

Improvements:

  • Details ...

Before & After Screenshots

BEFORE:
{shows gender}

AFTER:

CHILD/ CHILDREN
image

SELF
image

INFOBOX
Child
image

Self
image

Tests

Time-based simulation. Can try toggling dates

Deploy Notes

Probably should scrub this after the transition/ remove the time-checks post 1-jul/ when this is expected to go live

@KenLSM hope this implementation makes sense! 🙏

  • will also check the excel export headers in the next PR
  • Confirm infobox implementation with @kennethchangOPENGOV (feel better soon!) and do it for the other MyInfo field

Copy link

linear bot commented Jun 10, 2024

shared/constants/field/myinfo/index.ts Outdated Show resolved Hide resolved
@ghostleek
Copy link
Contributor Author

@KenLSM @kennethchangOPENGOV lemme know if any other changes needed! 🙏 thanks for reviewing

@KenLSM KenLSM self-requested a review June 14, 2024 14:57
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for looking into this!

@KenLSM KenLSM merged commit 6b3aedb into develop Jun 14, 2024
11 checks passed
@KenLSM KenLSM deleted the feat/rename-gender-as-sex branch June 14, 2024 15:29
@KenLSM KenLSM mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants