Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrf): add response id to email title #7380

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jun 11, 2024

Problem

Closes FRM-1734

Solution

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Component Before After
Email Title Screenshot 2024-06-12 at 10 42 24 AM Screenshot 2024-06-12 at 10 40 26 AM

Tests

Emails subject received by subsequent respondents should contain response id

  • Create an MRF
  • Assign yourself as the email recipient of the next step in the workflow
  • Make a submission
  • Observe that an email is received
  • Observe that email subject contains response id
  • Ensure that response id on email subject is the same response id as per body

Copy link

linear bot commented Jun 11, 2024

Copy link
Contributor Author

KenLSM commented Jun 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @KenLSM and the rest of your teammates on Graphite Graphite

@KenLSM KenLSM changed the title add response id to email title feat(mrf): add response id to email title Jun 11, 2024
@KenLSM KenLSM marked this pull request as ready for review June 11, 2024 09:27
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I checked out mail.service.spec.ts and it doesn't seem like there are test cases for sendMRFWorkflowStepEmail.

Copy link
Contributor Author

KenLSM commented Jun 12, 2024

Merge activity

  • Jun 12, 11:17 AM EDT: @KenLSM started a stack merge that includes this pull request via Graphite.
  • Jun 12, 11:18 AM EDT: @KenLSM merged this pull request with Graphite.

@KenLSM KenLSM merged commit cfbda4a into develop Jun 12, 2024
38 of 39 checks passed
@KenLSM KenLSM deleted the feat/frm-1734-mrf-response-id-email branch June 12, 2024 15:18
@g-tejas g-tejas mentioned this pull request Jun 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants