Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.127.0 #7413

Merged
merged 9 commits into from
Jun 19, 2024
Merged

build: release v6.127.0 #7413

merged 9 commits into from
Jun 19, 2024

Conversation

g-tejas
Copy link
Contributor

@g-tejas g-tejas commented Jun 19, 2024

New

Dependencies

  • fix(deps): bump winston from 3.8.2 to 3.13.0 #7406
  • fix(deps): bump nodemailer and @types/nodemailer #7404

Dev-Dependencies

  • chore(deps-dev): bump @types/jwk-to-pem from 2.0.1 to 2.0.3 #7400

Tests

feat: email <> storage mode parity #7350

To test if use-template leaks admin emails

  • 1. Create a storage mode form
  • 2. Ensure that the newly created form has admin emails and is not empty
  • 3. Make the form public, and navigate to the live form
  • 4. Append "/use-template" to the url
  • 5. Click on the top right hand corner button "Use this template"
  • 6. Enter new form name, and click storage mode
  • 7. Navigate to the duplicate form general settings
  • 8. Observe that the emails setting is empty
  • 9. Repeat from step 5 onwards for email mode forms. Observe that the admin emails is empty.

fix(payment): add joi validation on POST body for payment onboarding #7405

Regression
  • Visit form.gov.sg/payments
  • Enter your whitelisted email
  • Ensure that the message "An email has been sent to this email address." is displayed
  • Ensure that the email is received in your inbox

dependabot bot and others added 9 commits June 17, 2024 17:51
Bumps [@types/jwk-to-pem](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jwk-to-pem) from 2.0.1 to 2.0.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jwk-to-pem)

---
updated-dependencies:
- dependency-name: "@types/jwk-to-pem"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge release v6.126.0 to develop
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) and [@types/nodemailer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nodemailer). These dependencies needed to be updated together.

Updates `nodemailer` from 6.9.12 to 6.9.13
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.9.12...v6.9.13)

Updates `@types/nodemailer` from 6.4.7 to 6.4.15
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nodemailer)

---
updated-dependencies:
- dependency-name: nodemailer
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: "@types/nodemailer"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [winston](https://github.com/winstonjs/winston) from 3.8.2 to 3.13.0.
- [Release notes](https://github.com/winstonjs/winston/releases)
- [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md)
- [Commits](winstonjs/winston@v3.8.2...v3.13.0)

---
updated-dependencies:
- dependency-name: winston
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7405)

* fix: add joi validation on POST body for payment onboarding

* chore: tighten validation

Co-authored-by: Tejas G. <code@gtejas.com>

---------

Co-authored-by: Tejas G. <code@gtejas.com>
chore: update date to 28 jun
* feat: add basic email notifications page

* feat: update storage form types

* feat: update validation rules and add helper fns

* rename email notifications page name

* refactor tab rendering logic

* fix(admin-form): update Joi validation wrt emails and publicKey fields

Fixes #2264 by disallowing publicKey field for email mode forms and
disallowing emails field if not Email or Encrypt mode.

* feat(model): add emails field to encrypt forms

* fix(frontend): fix issue when getValues returns undefined

* refactor: make dataCollationData optional and add common types

* feat(encrypt-submission): update encrypt submissions to send email notifs

* fix: replace deprecated opaque type with tagged

* refactor: move email notifications and show payments tab by default

* fix: update mutations to fix failing validation at form wizard

* fix: remove unused type predicates

* feat(frontend): exclude email notifications from payment forms

* fix: move tabConfig to top level and separate label from path

* refactor: remove redundant useMemo and add EmailNotificationsHeader

* fix: update encrypt form validation to have string[] only

* fix(admin-form): enforce emails to be empty when duplicating to encrypt

* fix(test:backend): add and modify tests for emails field in encrypt form

* fix(test): ensure processDuplicateOverrideProps returns empty emails for encrypt

* fix(test): update ENCRYPT_FORM_DEFAULTS to have emails field

* fix: add exhaustive switch for enums

* fix: move boolean calc out and fix inline message in payments page for test env

* fix: update form encrypt schema

* fix: add PaymentsNotAllowed component

* fix: update comment for /settings controller and remove emails from duplicate dto

* fix(admin-form): validate that payment forms don't have emails and vice versa

* fix: add helper to extract emails from form types

* fix: cleanup

* fix: update use-template mutations

* fix: update payment form and emails to be mutually exclusive

* fix: check payments_field.enabled instead of making stripe call

* fix: check both PaymentChannel and enabled field for payment forms

* feat: move email notifications into a new tab

* feat: reduce opacity at component level and add stories for email notifs

* fix: add common payment fields to fix chromatic tests

* fix: update wrong link and remove padding

* fix: fix lodash merge array bug for chromatic test

* fix: lodash merge should only overwrite if override arr is empty

* fix: fix chromatic reviews

* fix: fix tag input UI

* fix: ensure non-zero admin emails length before sending

* fix: move invalid payment config check to svc instead of controller

* fix: fix incorrect error thrown and add jest test case for invalid payment update

* fix: remove unused import and move jest test

* test: update e2e test for email notification in encrypt form

* fix: fix failing backend jest tests

* fix: check for null + undefined and fix style

* fix: improve rendering of tabs to avoid inserting via idx

* fix: render null if not email or encrypt form

* fix: increase encrypt-submission timeout for checking for emails

* fix(test): fix e2e tests for new email notifications tab
@KenLSM KenLSM merged commit 6c5e836 into release-al2 Jun 19, 2024
56 of 57 checks passed
@KenLSM KenLSM deleted the release_v6.127.0 branch June 19, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants