refactor: migrate utils/request to Typescript
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
I'm ok with this but also wondering if there's a better solution, given what @liangyuanruo said a couple of months ago about never passing the req or res objects to other functions
I think that's in regards to services, utilities like this I think is fine. Might want to have a central error handler then, then have that central handler inline this function. I think that can be taken a look at in the future after the full migration and cleanup of controllers and routes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Migrates
utils/requestto TypescriptRelated to #8