chore: make return more readable

opengovsg · Mar 18, 2024 · e51acc4 · e51acc4
1 parent 9c39135
commit e51acc4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/server/repositories/UrlRepository.ts b/src/server/repositories/UrlRepository.ts
@@ -184,9 +184,10 @@ export class UrlRepository implements UrlRepositoryInterface {
   ) => {
     try {
       // Cache lookup
+      await this.getLongUrlFromCache(shortUrl)
       // if long url does not exist, throws error
-      const longUrl = await this.getLongUrlFromCache(shortUrl)
-      return !longUrl
+      // return false if no error since long url exists
+      return false
     } catch {
       // Cache failed, look in database
       const url = await Url.findOne({