Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/node 14 #1858

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Chore/node 14 #1858

merged 2 commits into from
Jun 14, 2022

Conversation

gweiying
Copy link
Contributor

@gweiying gweiying commented Jun 13, 2022

Problem

What problem are you trying to solve? What issue does this close?

Node 12 has reached its EOL and no longer provides any security support. Currently, our Github CI actions for ci, testing and Sentry sourcemap compiling runs on Node 12, as well as our Serverless user functions. We upgrade these to run on Node 14.

Partially closes #1811

Solution

How did you solve the problem?

  • Upgraded GitHub Actions Node runtime from 12 to 14 on staging
  • Ran through release checklist on staging
  • Upgraded Serverless functions
  • Tested out Serverless functions

Deploy Notes

For the lambdas, we will have to reconfigure the VPC and the environment variables and test for functionality after deployment, as the VPC configurations and environment variables are dropped when the runtimes changes.

As these lambda functions are meant for internal use, we do not foresee this having any public impact. The reconfiguration + tests should not take longer than an hour.

@gweiying gweiying requested a review from yong-jie June 13, 2022 14:13
@gweiying gweiying marked this pull request as ready for review June 13, 2022 14:13
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just checking regarding the deploy notes, those are referring to the lambda functions and have nothing to do with our main app right?

@gweiying
Copy link
Contributor Author

lgtm! just checking regarding the deploy notes, those are referring to the lambda functions and have nothing to do with our main app right?

yup this is correct! added a clarification inline to address this

@gweiying gweiying merged commit 638a910 into develop Jun 14, 2022
@gweiying gweiying deleted the chore/node-14 branch June 14, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic for GoGov infra updates and monitoring (WIP)
2 participants