Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): remove excludeDevDependencies for capture-ses-events #1940

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

halfwhole
Copy link
Contributor

@halfwhole halfwhole commented Aug 25, 2022

Problem

GitHub action for the edge branch is failing at the serverless deploy step (example).

Likely because the serverless functions were upgraded to v3 in #1900 which involved removing excludeDevDepdencies, but the capture-ses-events lambda function from #1913 still had excludeDevDependencies that was incompatible with v3

Solution

Removed excludeDevDependencies: true from capture-ses-events, action now passes

Tests

  • Tested on health staging that's using SES, can see the logs for sending OTPs on CloudWatch

Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch! lgtm

@yong-jie yong-jie merged commit 6c43224 into develop Aug 25, 2022
@yong-jie yong-jie deleted the chore/lambda/fix-serverless-ses branch August 25, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants