-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment go <> sgid integration #2247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sgID implementation looks like it should work! left some clarifications and some questions - thanks Prakriti! 🎉
26f0bf3
to
6a16fe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor nit comments. Overall, good job @PikkaPikkachu with the implementation! Awesome work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks so much for this 🥳
the overall flow looks great, left a bunch of minor comments below but they're very much non-blocking so feel free to merge!
One additional comment from me, let's check the behavior on staging.for.edu.sg and staging.for.sg for the sgid login request endpoint to verify that it's not throwing any weird errors! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, apart from the first comment below!
Problem
We are trying to integrate SGID with GO and will be testing it with OGP officers. If the integration is successful, we will open this up to other public officers as well.
Solution
Integration doc with the detailed solution here, for summary refer below:
Followed developer docs here
/ogp-login
.gov.sg
Features:
Login feature with SGID
Before & After Screenshots
AFTER:
Screen.Recording.2023-07-28.at.12.07.46.AM.mov
Tested on health and edu domains, we get a 400 response, with this error message on the UI:
Tests
What tests should be run to confirm functionality?
Deploy Notes
Need to create the relevant environment variables before deploying.
There might be a need to use the AWS key manager, in case env variable store in EB does not work.
New environment variables: