Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump webpack-dev-server from 3 to 4 #2291

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

halfwhole
Copy link
Contributor

@halfwhole halfwhole commented Feb 15, 2024

Problem

There's a high-severity Snyk security issue from using ansi-regex v2.1.1. This package is used by strip-ansi v3, which is in turn required by webpack-dev-server v3.

Solution

Upgrade webpack-dev-server from v3 to v4.

  • This major version upgrade comes with breaking changes (see migration guide). So we have to change disableHostCheck: true to allowedHosts: 'all'
  • Sadly, this upgrade doesn't seem to speed up the dev server :/ It's still slow

Tests

  • Test that the dev server still works
  • Test that staging still works

@halfwhole halfwhole marked this pull request as ready for review February 15, 2024 09:39
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the upgrade

@halfwhole halfwhole merged commit a71d1a9 into develop Feb 19, 2024
32 checks passed
@halfwhole halfwhole deleted the build/deps/webpack-dev-server branch February 19, 2024 07:28
@halfwhole halfwhole mentioned this pull request Feb 19, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants