build(deps): bump helmet from 3.23.3 to 4.0.0 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/helmet-4.0.0
branch
from
6a4704e
to
69de501
Compare
|
This change will disable Justification for the change can be found at helmetjs/helmet#230 - tl;dr - enabling this is ineffective |
liangyuanruo
previously approved these changes
Aug 6, 2020
There was a problem hiding this comment.
lgtm, please test extensively if you haven't, especially on the more obscure features like GA on the transition page. the changelog is long; but i didn't identify anything obvious that would break.
LoneRifle
dismissed
liangyuanruo’s stale review
Testing revealed helmet overriding custom CSP
LoneRifle
force-pushed
the
dependabot/npm_and_yarn/helmet-4.0.0
branch
3 times, most recently
from
27ba630
to
50d0f24
Compare
Bumps [helmet](https://github.com/helmetjs/helmet) from 3.23.3 to 4.0.0. - [Release notes](https://github.com/helmetjs/helmet/releases) - [Changelog](https://github.com/helmetjs/helmet/blob/master/CHANGELOG.md) - [Commits](helmetjs/helmet@v3.23.3...v4.0.0) Signed-off-by: dependabot[bot] <support@github.com>
LoneRifle
force-pushed
the
dependabot/npm_and_yarn/helmet-4.0.0
branch
from
50d0f24
to
5953f95
Compare
liangyuanruo
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps helmet from 3.23.3 to 4.0.0.
Changelog
Sourced from helmet's changelog.
Commits
bdb09344.0.0926ef63Prepare 4.0.0 release6d3f028Update changelog for 4.0.0 release4fbf5bdUpdate devDependencies to latest versionsc9926dbRemovehomepagefield from middleware package.jsons83508e84.0.0-rc.254525e5Export HelmetOptions typec813f914.0.0-rc.1fc2f745Use angle brackets around links in error messagese657b0bMove "simple" middleware functions inlineDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)