Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page tweaks #92

Merged
merged 9 commits into from
May 20, 2020
Merged

Home page tweaks #92

merged 9 commits into from
May 20, 2020

Conversation

JasonChong96
Copy link
Contributor

@JasonChong96 JasonChong96 commented May 18, 2020

Problem

The home page implementation differs from the current design.

Closes [#89]

Solution

The home page has been tweaked to match the design (other than file upload related elements).

Improvements

Analytics icon should load correctly now

Before & After Screenshots

BEFORE:
PC:
Image 1

Samsung Note 9:
Image 1

AFTER:
PC:
Image 1

Phone X (Simulated):
Image 1
Image 2

iPad Pro (Simulated):
Image 1

Samsung Note 9:
Image 1

Copy link
Contributor

@kylerwsm kylerwsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. At the same time, given that we have quite a lot of graphical assets now, what are your opinions on encapsulating assets into the relevant components?

src/client/theme/index.js Outdated Show resolved Hide resolved
src/client/components/HomePage/StatisticsGraphic/index.jsx Outdated Show resolved Hide resolved
@JasonChong96
Copy link
Contributor Author

JasonChong96 commented May 19, 2020

Added some comments. At the same time, given that we have quite a lot of graphical assets now, what are your opinions on encapsulating assets into the relevant components?

I think its a good idea since some of the component files are getting rather long

@kylerwsm kylerwsm self-requested a review May 19, 2020 17:17
Copy link
Contributor

@kylerwsm kylerwsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. But I think there are some changes to be done for the font sizes after the theme changes, such as the sign-in text (before, after) and the footer. Might be good to run through the rest of the pages as well to see if everything looks fine.

And thanks for working on this, it's really tedious work!

@JasonChong96
Copy link
Contributor Author

JasonChong96 commented May 19, 2020

Changes look good. But I think there are some changes to be done for the font sizes after the theme changes, such as the sign-in text (before, after) and the footer. Might be good to run through the rest of the pages as well to see if everything looks fine.

And thanks for working on this, it's really tedious work!

Resolved the sign-in text issue.

@kylerwsm kylerwsm self-requested a review May 20, 2020 10:01
Copy link
Contributor

@kylerwsm kylerwsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JasonChong96 JasonChong96 merged commit 1be5e27 into develop May 20, 2020
@JasonChong96 JasonChong96 deleted the home-page-tweaks branch May 22, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants