Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FormField): account for table responses #44

Merged
merged 1 commit into from
Oct 26, 2020
Merged

fix(FormField): account for table responses #44

merged 1 commit into from
Oct 26, 2020

Conversation

LoneRifle
Copy link
Contributor

Responses containing tabular data take the form string[][], but this is
not reflected in the appropriate answerArray. Change the type declaration
to accommodate.

@LoneRifle LoneRifle requested a review from karrui October 26, 2020 06:16
karrui
karrui approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit b555d53 into master Oct 26, 2020
@LoneRifle LoneRifle deleted the fix/form-field/table-responses branch October 26, 2020 06:21
liangyuanruo pushed a commit that referenced this pull request Jan 27, 2021
@LoneRifle
fix(FormField): account for table responses (#44)
1982116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LoneRifle @karrui