Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add downloadAndDecryptAttachments for downloading and decrypting attachments #62

Merged
merged 9 commits into from
May 14, 2021

Conversation

frankchn
Copy link
Contributor

@frankchn frankchn commented May 2, 2021

Adding support for downloading and decrypting attachments sent via webhooks.

Corresponding client-side PR to opengovsg/FormSG#1713

Closes #60

src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@mantariksh mantariksh requested a review from karrui May 3, 2021 03:03
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
frankchn and others added 2 commits May 4, 2021 22:26
Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
@frankchn frankchn requested a review from seaerchin May 7, 2021 06:59
src/crypto.ts Outdated Show resolved Hide resolved
src/crypto.ts Outdated Show resolved Hide resolved
@mantariksh
Copy link
Contributor

will test this against your branch on the main repo before approving!

Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, we can remove the type annotations in the comments in the README code sample

Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while testing on staging, I realised attachment fields are still disabled in the Build tab when the form has a webhook. we should remove that restriction.

@mantariksh mantariksh dismissed their stale review May 14, 2021 03:25

whoops, left this comment in the wrong repo

@mantariksh mantariksh merged commit c3ca99f into develop May 14, 2021
@frankchn frankchn deleted the frank-decrypt-attachment branch May 14, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add downloadAttachments utility function
4 participants