Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more sgid scopes #605

Merged
merged 3 commits into from
Oct 9, 2023
Merged

feat: add more sgid scopes #605

merged 3 commits into from
Oct 9, 2023

Conversation

PrawiraGenestonlia
Copy link
Collaborator

Context

sgID is a government identity provider that provides Myinfo data.

Problem

There are missing some fields that sgID is supporting, hence, RP is not able to test them.

Solution

Add the following scopes:

          'myinfo.birth_country',
          'myinfo.vehicles',
          'myinfo.name_of_employer',
          'myinfo.workpass_status',
          'myinfo.workpass_expiry_date',
          'myinfo.marital_status',
          'myinfo.mobile_number_with_prefix',

Default missing fields to NA instead of undefined.

Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit 4fea33a into master Oct 9, 2023
3 checks passed
@LoneRifle LoneRifle deleted the feat/add-more-sgid-scopes branch October 9, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants