Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong desc when residentialstatus is code=C #637

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

cflee
Copy link
Contributor

@cflee cflee commented Mar 14, 2024

Problem

  • Mockpass' sgID userinfo endpoint response has residentialstatus as Citizen, but production sgID response has CITIZEN
  • Similarly Myinfo v3 API docs' example has CITIZEN in the desc field for this case

(I don't know if the other values like PR are correct. Also production sgID returns NA for foreigners, and not ALIEN, but mockpass doesn't have personas that reflect that right now and I'm not sure how the real Myinfo v3 handles it.)

Solution

Bug Fixes:

  • Update myinfo personas file to replace the desc string from Citizen to CITIZEN where residentialstatus has code C.

Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit fae7976 into opengovsg:main Mar 14, 2024
3 checks passed
@cflee cflee deleted the cflee/fix-residentialstatus-desc branch April 5, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants