fix parse() arguments to match the documented types

[moshest]

Problem

What problem are you trying to solve? What issue does this close?

The pdf2md say it will receive the following type:

@param {string|TypedArray|DocumentInitParameters|PDFDataRangeTransport} pdfBuffer
 * Passed to `pdfjs.getDocument()` to read a PDF document for conversion

However, it only works with BinaryData type.

Solution

How did you solve the problem?

I add a type check and make the first argument convert to docOptions depends on the type given:

if (typeof docOptions === "string" || docOptions instanceof URL) {
  docOptions = { url: docOptions };
} else if (docOptions instanceof ArrayBuffer || ArrayBuffer.isView(docOptions)) {
  docOptions = { data: docOptions };
}

This should match the docs of pdfjs:
https://mozilla.github.io/pdf.js/api/draft/module-pdfjsLib.html

[LoneRifle]

lgtm

[LoneRifle]

Hang on. it's possible for docOptions to be a string but not a URL, ie, a binary string that represents the PDF blob itself. Could there be a stronger check to validate docOptions as something we can actually supply as a url to pdfjs?

[moshest]

I don't think we need to be holier than the pope:
https://github.com/mozilla/pdf.js/blob/12875359c387d7e2d312c50748833b3c52d986aa/src/display/api.js#L234

function getDocument(src) {
   // ...

   if (typeof src === "string" || src instanceof URL) {
      src = { url: src };
    } else if (isArrayBuffer(src)) {
      src = { data: src };
    }

    // ...
}