refactor: prevent filtering on OPEN or SEND

opengovsg · Sep 13, 2023 · 4ff780e · 4ff780e
1 parent f4cd7b7
commit 4ff780e
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/backend/src/email/utils/callback/parsers/ses.ts b/backend/src/email/utils/callback/parsers/ses.ts
@@ -137,7 +137,7 @@ const parseNotificationAndEvent = async (
   message: any,
   metadata: Metadata
 ): Promise<void> => {
-  if (!isNotificationAndEventForMainRecipient(message)) {
+  if (!isNotificationAndEventForMainRecipient(message, type)) {
     logger.info({
       message: 'SES notification or event is not for the main recipient',
       action: 'filterNotification',
@@ -259,8 +259,14 @@ const parseRecord = async (record: SesRecord): Promise<void> => {
 }
 
 // Checks whether the notification/event is meant for the main recipient of the email.
-// We cannot check "OPEN" and "SEND" events due to the response given by AWS SES
-function isNotificationAndEventForMainRecipient(message: any): boolean {
+function isNotificationAndEventForMainRecipient(
+  message: any,
+  type: SesEventType
+): boolean {
+  // We cannot filter "OPEN" and "SEND" events due to the response given by AWS SES
+  if (type === SesEventType.Open || type === SesEventType.Send) {
+    return true
+  }
   const mainRecipient = message?.mail?.commonHeaders?.to
   if (!mainRecipient) {
     throw new Error('Failed to find main recipient in message')